Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][Promptflow SDK& CLI] docker build build is confusing #379

Merged
merged 4 commits into from
Sep 14, 2023
Merged

[BUG][Promptflow SDK& CLI] docker build build is confusing #379

merged 4 commits into from
Sep 14, 2023

Conversation

YingChen1996
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@YingChen1996 YingChen1996 requested a review from a team as a code owner September 13, 2023 02:39
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 13, 2023
@github-actions github-actions bot added the examples Improvements on examples label Sep 13, 2023
@YingChen1996 YingChen1996 merged commit 3f8b7f4 into main Sep 14, 2023
@YingChen1996 YingChen1996 deleted the chenyin/update_docker_doc branch September 14, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@brynn-code brynn-code brynn-code approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples Improvements on examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YingChen1996 @brynn-code @wangchao1230